Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support solana authentication #22

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Support solana authentication #22

merged 4 commits into from
Dec 8, 2023

Conversation

aminlatifi
Copy link
Member

No description provided.

@aminlatifi
Copy link
Member Author

Ref Giveth/giveth-dapps-v2#3400

@aminlatifi aminlatifi marked this pull request as draft December 5, 2023 16:31
@aminlatifi
Remove commented lines
0488921
@aminlatifi
Removed local.env
fabd80a
@aminlatifi
Changed solana authentication parameters
47ed1ff 
* It's not needed to pass whole SWIS payload, only address and nonce are sufficient
@aminlatifi aminlatifi marked this pull request as ready for review December 6, 2023 09:31
@aminlatifi aminlatifi mentioned this pull request Dec 6, 2023
Closed
CarlosQ96
CarlosQ96 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Changes Amin! I like the refactored Logic and shared method. I agree two different routes was the best approach

jainkrati
jainkrati reviewed Dec 7, 2023
View reviewed changes
package.json Show resolved Hide resolved
@aminlatifi aminlatifi requested a review from jainkrati December 8, 2023 08:33
@jainkrati jainkrati merged commit f35a757 into staging Dec 8, 2023
3 checks passed
@aminlatifi aminlatifi deleted the feat/solana_authentication branch December 9, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

@mohammadranjbarz mohammadranjbarz Awaiting requested review from mohammadranjbarz

@jainkrati jainkrati Awaiting requested review from jainkrati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aminlatifi @jainkrati @CarlosQ96